If you re-purpose containers that were originally designed for something else, some of the details to pay attention to are:
1) what material is the container made from? (already covered above)
2) can the lid be fully sealed and re-sealed (be cautious of cardboard liners)?
3) is the container easy to handle or slippery and hard to handle?
4) will the container fit in the space you have for it?
5) how big is the opening - important for containers that you are filling and emptying regularly, but not so important for containers that are filled infrequently?
6) is the container easy to clean thoroughly (avoid nooks and crannies)?
Consider using different containers for different purposes - long term storage vs. use and re-use.
Don't get all caught up in extracting every last bit of use out of every milliliter of chemical - a new package of XTol every 6 months is not that expensive!
For the working solution for my replenished developer - HC110 not XTol - I use 64 US ounce Clamato Juice containers - note the moderately wide lid and (hard to see) built in handle:
They have the additional benefit of being relatively short.