I would think that photographers who do product ads, brochures etc are the ones who make money along with wedding photographers. I still get loads of store and product magazines and flyers. Also from cruise ships and travels places like hotels etc. Pro photographers have to do these shots. If you want to make money in photography, you have to target the opportunity. It doesn;t seem stock is the way to go.
If the company you're shooting for is big enough, or the wedding party is rich enough, then there is indeed money to be made. However, most small companies put no value on this type of work. And most wedding parties will gladly hire this job out to a friend to save a few bucks (weddings are crazy expensive as it is).
My wife did both. The last job catalog she shot was for about 2,000 images of various auto transmission parts. He originally offered to pay her 10 cents a photo. His argument was the camera did all of the work and all she had to do was click a button. After months of negotiations, she finally got him up to $3 a photo. After it was all done, she gave him the photos and he tried to stiff her on the money. She had to threaten to hire a lawyer and remind him the contract he signed meant he would lose in court, and have to pay her legal fees and court costs. Months later, he finally paid her. This is a company that has about 100 employees and does business all over the world, so you know they had no problem coming up with $6,000. Later, this same company called her up and asked her to steal photos from a competitor's website and remove their watermarks to use on their own. She refused and reminded him it was illegal. He argued that every photo on the internet is free and yelled at her for refusing him. He still calls her about once a year to see if he can get more photos from her, but she refuses, as it just isn't worth her time.
Unfortunately, this isn't the only company like that. There are probably more companies that operate like this in the U.S. than don't. I do graphic design and am constantly getting asked to violate copyright law (I was even fired for a job because I refused to steal footage from a major motion picture without written consent and when I tried to sue them, my lawyer advised me that they would likely deny ever asking me to do that, and without written proof, I would have no case and under state law, they can fire me for any reason outside of me being part of a protected class, including no reason at all).
Wedding photography is even worse. The guests will try everything to ruin your shots (like literally, because some are mad at you because they weren't asked to shoot the wedding). The family members will often send you to other family members to collect your money in an endless loop of denial. Then, after going through months of trouble, you finally take the bride and groom to court. Only they don't show. And they lose. But the judge can't do much, outside of putting lean on their home or something. Then they get foreclosed on their house and skip town and the bank takes over the house, and you have to take the bank to court. Suddenly you've spent more money on lawyers than you're owed.
Technology has robbed any respect for creativity in this world. Everyone assumes anyone can take a photo. Everyone assumes you're born with the ability to draw, and everyone has a nephew who can draw and will do it for free. Everyone assumes that owning a DSLR makes you a pro because the camera does all of the work. Everyone assumes typography is easy because of Helvetica. And everyone assumes negative space is a waste of space.
I'm not saying you CAN'T make money as a photographer or a creative. I'm just saying that unless your clients are big enough to be listed on the NYSE or rich enough to drop $50k+ on a wedding, it's going to be really difficult to make ends meet every month without a second source of income.